Skip to content

Merge and add benchmarks to palindrome algorithms in the strings/ directory #8749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 25, 2023
Merged

Merge and add benchmarks to palindrome algorithms in the strings/ directory #8749

merged 7 commits into from
May 25, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

There is an is_palindrome file and a palindrome file so merging them keeps consistency and allows someone to explore all implementations at the same time

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@CaedenPH
Copy link
Contributor Author

@cclauss Could you review this and #8738 when you get time please

cclauss
cclauss reviewed May 25, 2023
View reviewed changes
cclauss
cclauss reviewed May 25, 2023
View reviewed changes
cclauss
cclauss reviewed May 25, 2023
View reviewed changes
@CaedenPH @cclauss
Update strings/palindrome.py
da3003a 
Co-authored-by: Christian Clauss <[email protected]>
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 25, 2023
@github-actions github-actions bot force-pushed the merge-palindromic-algorithms branch from 28b85be to da3003a Compare May 25, 2023 10:35
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 25, 2023
@cclauss cclauss enabled auto-merge (squash) May 25, 2023 10:55
cclauss
cclauss approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cclauss cclauss merged commit cfbbfd9 into TheAlgorithms:master May 25, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label May 25, 2023
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@CaedenPH @cclauss @tianyizheng02
Merge and add benchmarks to palindrome algorithms in the strings/ dir…
155924b 
…ectory (TheAlgorithms#8749)

* refactor: Merge and add benchmarks to palindrome

* updating DIRECTORY.md

* chore: Fix failing tests

* Update strings/palindrome.py

Co-authored-by: Christian Clauss <[email protected]>

* Update palindrome.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@CaedenPH CaedenPH deleted the merge-palindromic-algorithms branch August 22, 2023 09:38
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @cclauss @sedatguzelsemme
Merge and add benchmarks to palindrome algorithms in the strings/ dir…
56baae5 
…ectory (TheAlgorithms#8749)

* refactor: Merge and add benchmarks to palindrome

* updating DIRECTORY.md

* chore: Fix failing tests

* Update strings/palindrome.py

Co-authored-by: Christian Clauss <[email protected]>

* Update palindrome.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @cclauss